Replace PERFSCORE memory access kind macros with enum class#127046
Draft
Replace PERFSCORE memory access kind macros with enum class#127046
Conversation
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/06108608-ff5f-462f-b0d4-4d1edd8dfd9e Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jakobbotsch
April 17, 2026 05:20
View session
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
reviewed
Apr 17, 2026
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/953ca121-6617-4be3-ab12-6b6b4843c5c8 Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
Copilot
AI
changed the title
Replace PERFSCORE memory access kind macros with enum
Replace PERFSCORE memory access kind macros with enum class
Apr 17, 2026
jakobbotsch
reviewed
Apr 17, 2026
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a1e05837-c443-40b6-9041-07f4760bdafd Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PERFSCORE_MEMORY_*macro constants insrc/coreclr/jit/emit.hwith a strongly-typedPerfScoreMemoryAccessKindenum classNone,Read,Write, andReadWriteinsExecutionCharacteristics.insMemoryAccessKindasPerfScoreMemoryAccessKindPerfScoreMemoryAccessKind::None,::Read,::Write,::ReadWrite) across xarch/arm64/loongarch64/riscv64 and shared perfscore logicPerfScoreMemoryAccessKind*instead ofunsigned*Validation
./build.sh clr+libs+host(baseline)./build.sh clr.jit -rc release./build.sh clr.jit -rc release -testparallel_validation(Code Review: no comments, CodeQL: no alerts; cpp analysis skipped due database size)Note
This pull request description was generated with AI assistance.