Skip to content

JIT: Fix loongarch64 Windows build#127018

Merged
jakobbotsch merged 1 commit intodotnet:mainfrom
jakobbotsch:fix-windows-loongarch-build
Apr 16, 2026
Merged

JIT: Fix loongarch64 Windows build#127018
jakobbotsch merged 1 commit intodotnet:mainfrom
jakobbotsch:fix-windows-loongarch-build

Conversation

@jakobbotsch
Copy link
Copy Markdown
Member

@jakobbotsch jakobbotsch commented Apr 16, 2026

#126938 introduced a superpmi-diffs Windows build break that I missed when merging it.

cc @LuckyXu-HF @shushanhf @dotnet/jit-contrib

Copilot AI review requested due to automatic review settings April 16, 2026 17:32
@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 16, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a Windows build break introduced by #126938 in LoongArch64 JIT perfscore modeling by correcting the value assigned to insMemoryAccessKind.

Changes:

  • Replace incorrect assignments of PERFSCORE_LATENCY_RD_STACK (a latency value) to result.insMemoryAccessKind with PERFSCORE_MEMORY_READ (a memory-access-kind value).

@jakobbotsch
Copy link
Copy Markdown
Member Author

/ba-g Build break fix in loongarch64, validated locally, merging early

@jakobbotsch jakobbotsch merged commit b4a1c4e into dotnet:main Apr 16, 2026
31 of 116 checks passed
@LuckyXu-HF
Copy link
Copy Markdown
Contributor

Thank you, I'm sorry for introduced this break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants