Conversation
There was a problem hiding this comment.
Pull request overview
Reduces macOS CI load by shrinking the Apple mobile test matrix (iOS/tvOS simulators/devices and MacCatalyst), aiming to keep coverage focused on common developer/user scenarios while removing redundant jobs.
Changes:
runtime.yml: drop tvOS device from mobile smoke jobs and remove the MacCatalyst Mono smoke entry.runtime-extra-platforms-ioslike.yml: shift iOS-like device coverage to tvOS-only.runtime-extra-platforms-ioslikesimulator.yml: focus simulator coverage on iOS simulator only, switch to Debug, and remove NativeAOT simulator runtime tests.runtime-extra-platforms-maccatalyst.yml: remove MacCatalyst x64 coverage (arm64 only).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| eng/pipelines/runtime.yml | Removes tvOS device and MacCatalyst smoke jobs from the default runtime pipeline’s Apple-mobile matrix. |
| eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.yml | Removes iOS device runs so iOS-like device testing is tvOS-only in extra-platforms. |
| eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml | Narrows simulator jobs to iOS simulator, switches to Debug, and drops NativeAOT simulator runtime tests. |
| eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml | Drops MacCatalyst x64 from extra-platforms, leaving arm64 only. |
You can also share your feedback on Copilot code review. Take the survey.
eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml
Show resolved
Hide resolved
eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml
Show resolved
Hide resolved
eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml
Show resolved
Hide resolved
|
I didn't look at the existing coverage, so maybe this is already covered:
|
Reduce the Apple mobile test matrix from 47 to 24 jobs (-23 per run), restructured around real user scenarios: - runtime.yml: iOS-only smoke tests (8 -> 3 jobs) Remove tvos_arm64 from smoke tests, remove maccatalyst Mono_Smoke - ioslike.yml: tvOS devices only in Release (12 -> 6 jobs) Remove ios_arm64 (covered by runtime.yml smoke) - ioslikesimulator.yml: iossimulator only in Debug (15 -> 8 jobs) Remove tvossimulator, change Release to Debug, drop NativeAOT - maccatalyst.yml: arm64 only (12 -> 7 jobs) Remove maccatalyst_x64 (Intel Macs EOL) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
88bd5b0 to
ce99125
Compare
…urations for clarity
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review. Take the survey.
… exclusions from tests
…ous crashes on tvOS
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
You can also share your feedback on Copilot code review. Take the survey.
eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml
Outdated
Show resolved
Hide resolved
- Restore MacCatalyst Mono + CoreCLR + NativeAOT smoke in runtime.yml - Add NativeAOT library smoke to ioslikesimulator and maccatalyst - Replace NativeAOT runtime tests with library tests in maccatalyst - Add CoreCLR AppSandbox library tests for maccatalyst - Change maccatalyst CoreCLR x64+arm64 from smoke to full library tests - Use x64 only for library tests in ioslikesimulator - Reorder entries: Mono > NativeAOT > CoreCLR, library > runtime Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…uce-apple-ci-matrix # Conflicts: # eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.yml # eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml
Ok, sounds good. Reverted to test Release.
Yes, sometimes a debug assert is hit. For that reason, it introduces just one job for the default config per platform to run in Debug to catch such errors. |
src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedFile.CreateFromFile.Tests.cs
Show resolved
Hide resolved
Add maccatalyst_arm64 smoke tests for all three runtimes to the default pipeline to catch PR breakages early. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Impact of this PR:
|
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
matouskozak
left a comment
There was a problem hiding this comment.
LGTM! Thanks a lot. Let's monitor for a few days the times of the iOS device runs from runtime pipeline and see if they are able to handle the load well.
| testGroup: innerloop | ||
| nameSuffix: AllSubsets_NativeAOT_Smoke | ||
| buildArgs: --cross -s clr.alljits+clr.tools+clr.nativeaotruntime+clr.nativeaotlibs+libs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:RunSmokeTestsOnly=true /p:DevTeamProvisioning=- /p:BuildTestsOnHelix=true /p:UseNativeAOTRuntime=true /p:RunAOTCompilation=false /p:ContinuousIntegrationBuild=true | ||
| timeoutInMinutes: 180 |
There was a problem hiding this comment.
The NativeAOT jobs outside of runtime.yml do not set useNativeAOTRuntime: true. Just a nit I don't think it's doing anything special.
steveisok
left a comment
There was a problem hiding this comment.
I'm supportive. I think devices are still going to have a hard time when they get into a state of needing to be rebooted.
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Reduce the Apple mobile CI test matrix to mitigate macOS queue congestion and align with the default scenarios.
What runs where
runtime.yml— ios + maccatalyst arm64 smoke (6 jobs)runtime-extra-platforms-ioslike.yml— tvos full + Debug smoke (6 jobs)runtime-extra-platforms-ioslikesimulator.yml— iossimulator Release + Debug smoke (9 jobs)runtime-extra-platforms-maccatalyst.yml— maccatalyst full + Debug smoke (12 jobs)Other changes
System.IO.Hashing.Tests,System.IO.MemoryMappedFiles.Tests,System.Runtime.Numerics.Tests)