Add stub implementation of SlhDsaCng and algorithm identifiers#117889
Merged
PranavSenthilnathan merged 5 commits intodotnet:mainfrom Jul 23, 2025
Merged
Add stub implementation of SlhDsaCng and algorithm identifiers#117889PranavSenthilnathan merged 5 commits intodotnet:mainfrom
PranavSenthilnathan merged 5 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a stub implementation of the Stateless Hash-based Digital Signature Algorithm (SLH-DSA) backed by CNG to establish the API surface for future implementation. The changes introduce experimental SLH-DSA algorithm identifiers and a CNG-based class that currently throws PlatformNotSupportedException for all operations.
- Adds SLH-DSA algorithm identifiers to CNG classes with experimental attributes
- Creates SlhDsaCng class with complete API surface but stub implementations
- Updates project files to include the new SlhDsaCng implementation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| CngAlgorithmGroup.cs | Adds SlhDsa algorithm group property with experimental attribute |
| CngAlgorithm.cs | Adds SlhDsa algorithm property with experimental attribute |
| System.Security.Cryptography.csproj | Includes SlhDsaCng.cs in compilation |
| System.Security.Cryptography.cs | Adds SlhDsaCng class to reference assembly |
| Microsoft.Bcl.Cryptography.csproj | Includes SlhDsaCng.cs in BCL project |
| SlhDsaCng.cs | Implements stub SlhDsaCng class with PNSE-throwing methods |
src/libraries/Common/src/System/Security/Cryptography/SlhDsaCng.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/SlhDsaCng.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/SlhDsaCng.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/SlhDsaCng.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/SlhDsaCng.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/SlhDsaCng.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/SlhDsaCng.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CngAlgorithm.cs
Outdated
Show resolved
Hide resolved
PranavSenthilnathan
approved these changes
Jul 21, 2025
bartonjs
approved these changes
Jul 21, 2025
Open
3 tasks
Member
|
/ba-g known timeout issues and wasm failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an
Experimentalimplementation of SLH-DSA backed by CNG that, for now, only throws PNSE. This will ensure we get the API surface shipped so that the implementation can be filled in later.