Follow up on recent PAL cleanups#116127
Merged
Merged
Conversation
jkotas
commented
May 30, 2025
jkotas
commented
Member
- Avoid extra layer in System.Diagnostics.Stopwatch
- Rename Millieseconds -> MillieSecond
- Delete types from NativeAOT PAL that are not longer needed
- Delete unused g_registerModuleTrace
jkotas
requested review from
MichalStrehovsky,
steveisok and
vitek-karas
as code owners
github-actions
Bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines time-related functionality by simplifying Stopwatch internals, standardizing millisecond naming in PAL, and cleaning up unused types in NativeAOT.
- Removed obsolete time conversion constants in mono-time.c
- Refactored Stopwatch to eliminate extra QueryPerformance* wrappers and unified GetFrequency/GetTimestamp implementations
- Corrected “MillieSeconds” naming to “MilliSeconds” across PAL and removed unused NativeAOT PAL types
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mono/mono/utils/mono-time.c | Deleted unused TimeConversionConstants enum |
| src/libraries/System.Private.CoreLib/src/System/Diagnostics/Stopwatch.cs | Inlined frequency/timestamp getters and removed wrapper methods |
| src/libraries/System.Private.CoreLib/src/System/Diagnostics/Stopwatch.Windows.cs | Renamed QueryPerformanceFrequency/QueryPerformanceCounter to GetFrequency/GetTimestamp |
| src/libraries/System.Private.CoreLib/src/System/Diagnostics/Stopwatch.Unix.cs | Renamed QueryPerformanceFrequency/QueryPerformanceCounter to GetFrequency/GetTimestamp |
| src/coreclr/pal/src/synchmgr/synchmanager.cpp | Updated timeout calculations to use corrected tccSecondsToMilliSeconds constants |
| src/coreclr/pal/src/misc/time.cpp | Fixed naming in millisecond conversion constant |
| src/coreclr/pal/src/include/pal/palinternal.h | Standardized TimeConversionConstants member names for milliseconds |
| src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp | Removed unused PalGetCurrentOSThreadId |
| src/coreclr/nativeaot/Runtime/startup.cpp | Deleted g_registerModuleTraces and related RegisterModuleTrace definitions |
| src/coreclr/nativeaot/Runtime/PalRedhawk.h | Pruned redundant LARGE_INTEGER and old exception/disposition definitions |
jkotas
commented
May 30, 2025
tannergooding
approved these changes
May 30, 2025
jkotas
commented
May 30, 2025
stephentoub
approved these changes
May 30, 2025
Member
Author
|
/ba-g opened issue #116170, but it is not getting matched |
teo-tsirpanis
added
area-PAL-coreclr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.