Skip to content

Fix HTTP/2 pings not working with zero connection lifetime #115735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 2 commits into from
Jun 18, 2025
Merged

Fix HTTP/2 pings not working with zero connection lifetime #115735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cc3ee0
Fix HTTP/2 pings with zero connection lifetime
Copilot May 19, 2025
dbfa998
Extend existing test instead of adding new ones
stephentoub Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...aries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPoolManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,13 @@ public HttpConnectionPoolManager(HttpConnectionSettings settings)
// However, we can only do such optimizations if we're not also tracking
// connections per server, as we use data in the associated data structures
// to do that tracking.
// Additionally, we should not avoid storing connections if keep-alive ping is configured,
// as the heartbeat timer is needed for ping functionality.
bool avoidStoringConnections =
settings._maxConnectionsPerServer == int.MaxValue &&
(settings._pooledConnectionIdleTimeout == TimeSpan.Zero ||
settings._pooledConnectionLifetime == TimeSpan.Zero);
settings._pooledConnectionLifetime == TimeSpan.Zero) &&
settings._keepAlivePingDelay == Timeout.InfiniteTimeSpan;

// Start out with the timer not running, since we have no pools.
// When it does run, run it with a frequency based on the idle timeout.
Expand Down
8 changes: 5 additions & 3 deletions ...raries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.Http2KeepAlivePing.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,16 +95,18 @@ await Http2LoopbackServer.CreateClientAndServerAsync(async uri =>

[OuterLoop("Runs long")]
[Theory]
[InlineData(HttpKeepAlivePingPolicy.Always)]
[InlineData(HttpKeepAlivePingPolicy.WithActiveRequests)]
public async Task KeepAliveConfigured_KeepAlivePingsAreSentAccordingToPolicy(HttpKeepAlivePingPolicy policy)
[InlineData(HttpKeepAlivePingPolicy.Always, -1)]
[InlineData(HttpKeepAlivePingPolicy.WithActiveRequests, -1)]
[InlineData(HttpKeepAlivePingPolicy.WithActiveRequests, 0)]
public async Task KeepAliveConfigured_KeepAlivePingsAreSentAccordingToPolicy(HttpKeepAlivePingPolicy policy, int connectionLifetimeMilliseconds)
{
await Http2LoopbackServer.CreateClientAndServerAsync(async uri =>
{
SocketsHttpHandler handler = CreateSocketsHttpHandler(allowAllCertificates: true);
handler.KeepAlivePingTimeout = TimeSpan.FromSeconds(10);
handler.KeepAlivePingPolicy = policy;
handler.KeepAlivePingDelay = TimeSpan.FromSeconds(1);
handler.PooledConnectionLifetime = TimeSpan.FromMilliseconds(connectionLifetimeMilliseconds);

using HttpClient client = new HttpClient(handler);
client.DefaultRequestVersion = HttpVersion.Version20;
Expand Down
Loading