Skip to content

Use whole-archive to ensure DAC exports are preserved#115309

Merged
hoyosjs merged 1 commit into
mainfrom
hoyosjs-patch-2
May 5, 2025
Merged

Use whole-archive to ensure DAC exports are preserved#115309
hoyosjs merged 1 commit into
mainfrom
hoyosjs-patch-2

Conversation

@hoyosjs

@hoyosjs hoyosjs commented May 5, 2025

Copy link
Copy Markdown
Member

Fixes #115245

  • daccess and corguids archives are needed for DAC initialization
  • Preserving PAL in DAC is needed for DBI to use a consistent PAL.

Copilot AI review requested due to automatic review settings May 5, 2025 18:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/coreclr/dlls/mscordac/CMakeLists.txt: Language not supported

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@hoyosjs hoyosjs merged commit de08ba0 into main May 5, 2025
93 of 96 checks passed
@hoyosjs hoyosjs deleted the hoyosjs-patch-2 branch May 5, 2025 22:55
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[createdump] InitializeDAC: GetProcAddress(CLRDataCreateInstance) Failure

4 participants