Add a test to validate hostfxr C API#110169
Merged
elinor-fung merged 1 commit intodotnet:mainfrom Nov 26, 2024
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
7aa4875 to
37fe3b5
Compare
Member
Author
|
e.g. without the struct keyword, it failed to build tests |
am11
commented
Nov 26, 2024
|
|
||
| typedef void(HOSTFXR_CALLTYPE* hostfxr_get_dotnet_environment_info_result_fn)( | ||
| const struct hostfxr_dotnet_environment_info* info, | ||
| void* result_context); |
Member
Author
There was a problem hiding this comment.
Had to move it after the struct hostfxr_dotnet_environment_framework_info is defined, to fix:
In file included from /Users/am11/projects/runtime5/src/native/corehost/test/mockhostfxr/test_c_api.c:8:
/Users/am11/projects/runtime5/src/native/corehost/hostfxr.h:91:18: error: declaration of 'struct hostfxr_dotnet_environment_info' will not be visible outside of this function [-Werror,-Wvisibility]
91 | const struct hostfxr_dotnet_environment_info* info,
| ^
1 error generated.
make[2]: *** [test/mockhostfxr/CMakeFiles/mockhostfxr_2_2.dir/test_c_api.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
Member
Author
|
Backport together with #110060, since it fixes another ordering issue related to C vs. C++. |
elinor-fung
pushed a commit
that referenced
this pull request
Nov 26, 2024
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test for #109763 and align the style as headers in
src/native/minipal/*.h.