Skip to content

Add $(crossArg) to superpmi-collect-job#107277

Closed
jakobbotsch wants to merge 1 commit into
dotnet:mainfrom
jakobbotsch:fix-superpmi-collect
Closed

Add $(crossArg) to superpmi-collect-job#107277
jakobbotsch wants to merge 1 commit into
dotnet:mainfrom
jakobbotsch:fix-superpmi-collect

Conversation

@jakobbotsch

Copy link
Copy Markdown
Member

Similar to #107229, fixes superpmi-collect/superpmi-collect-test.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 3, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch

Copy link
Copy Markdown
Member Author

PTAL @dotnet/jit-contrib

This fixes superpmi-collect on Linux.

@jakobbotsch jakobbotsch requested a review from a team September 3, 2024 07:22
@am11

am11 commented Sep 4, 2024

Copy link
Copy Markdown
Member

Similar to #107229

The difference is that pipeline uses the prereq container which has lld installed and this one is on host which may or may not have it. Please run the pipeline to make sure. In case it's missing, we can add the eng/install-native-dependencies.sh invocation to resolve it.

@BruceForstall

Copy link
Copy Markdown
Contributor

Close in favor of #107588

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants