Skip to content

Code cleanup: remove TODO-ASG with zero diff quirk in lclmorph #106889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JulieLeeMSFT wants to merge 1 commit into from
Closed

Code cleanup: remove TODO-ASG with zero diff quirk in lclmorph #106889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/coreclr/jit/lclmorph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1829,7 +1829,6 @@ class LocalAddressVisitor final : public GenTreeVisitor<LocalAddressVisitor>
else
{
node->ChangeOper(GT_LCL_VAR);
node->gtFlags &= (GTF_NODE_MASK | GTF_DONT_CSE); // TODO-ASG-Cleanup: delete this zero-diff quirk.

@kasperk81 kasperk81 Aug 23, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SingleAccretion's pr is replacing it with empty node https://github.com/dotnet/runtime/pull/86726/files#diff-bd3095cf3bd9e41e7df84eb759f6983966aed4f2baab6179cd7759dfbcca3c1a

@JulieLeeMSFT JulieLeeMSFT Aug 23, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasperk81, thanks for pointing me to @SingleAccretion's PR.
I see that he is still working on the PR. So, I will close mine.

}
node->AsLclVar()->SetLclNum(fieldLclNum);
node->gtType = fieldType;
Expand Down