Skip to content

Remove the rest of the SimdAsHWIntrinsic support#106594

Merged
tannergooding merged 2 commits into
dotnet:mainfrom
tannergooding:simdashwintrinsic
Oct 31, 2024
Merged

Remove the rest of the SimdAsHWIntrinsic support#106594
tannergooding merged 2 commits into
dotnet:mainfrom
tannergooding:simdashwintrinsic

Conversation

@tannergooding

Copy link
Copy Markdown
Member

This removes quite a bit of complexity and ensures that Vector<T> handling is identical to the handling for the fixed sized vector types on exposed APIs.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 18, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@tannergooding

Copy link
Copy Markdown
Member Author

This one is for .NET 10 only, it does not need backport

@tannergooding tannergooding added this to the 10.0.0 milestone Aug 26, 2024
@tannergooding

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr jitstress-isas-x86, jitstress-isas-arm64, Fuzzlyn

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@tannergooding

Copy link
Copy Markdown
Member Author

CC. @dotnet/jit-contrib This is ready for review.

This removes the last of the handling that was specific to System.Numerics.* namespace and fully unifies it with the handling in the System.Runtime.Intrinsics.* namespace by mapping across the APIs during import.

This results in some fairly significant size and throughput wins for both x64 and Arm64, mostly stemming from places that the System.Numerics.* handling wasn't going down the same code paths and lighting up the same scenarios: https://dev.azure.com/dnceng-public/public/_build/results?buildId=856735&view=ms.vss-build-web.run-extensions-tab

@EgorBo EgorBo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up! I've noticed some missing ternary ops (avx512) among the regressions but I guess it's not a big deal

@tannergooding

Copy link
Copy Markdown
Member Author

I've noticed some missing ternary ops (avx512) among the regressions but I guess it's not a big deal

Yeah, we've got a tracking issue for those: #107619 and #90075

We get a lot of the cases, but there's a bit of slightly more advanced folding we still want to handle

@kunalspathak kunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants