Skip to content

[release/9.0-rc1] Fix build break in CrossAOT_Mono crossaot builds#106589

Merged
lewing merged 1 commit into
release/9.0-rc1from
backport/pr-106578-to-release/9.0-rc1
Aug 18, 2024
Merged

[release/9.0-rc1] Fix build break in CrossAOT_Mono crossaot builds#106589
lewing merged 1 commit into
release/9.0-rc1from
backport/pr-106578-to-release/9.0-rc1

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 18, 2024

Copy link
Copy Markdown
Contributor

Backport of #106578 to release/9.0-rc1

/cc @jkotas

Customer Impact

  • Customer reported
  • Found internally

Product does not build

Regression

  • Yes
  • No

Regression introduced by Visual Studio update on Windows build machines. #defines used by libz-ng started colliding with newly introduced symbols in Windows SDK.

Testing

Build passes

Risk

Low

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas requested review from carlossanlop and lewing August 18, 2024 17:41
@lewing lewing added the Servicing-approved Approved for servicing release label Aug 18, 2024
@lewing

lewing commented Aug 18, 2024

Copy link
Copy Markdown
Member

this is tell mode due to the broken official build

@lewing

lewing commented Aug 18, 2024

Copy link
Copy Markdown
Member

/ba-g analysis is always red on failure in servicing, issues are all logged and unrelated

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants