Include libz.a in native aot packages#106569
Merged
Merged
Conversation
jkotas
requested review from
carlossanlop
and removed request for
MichalStrehovsky
ghost
added
the
Member
Author
|
@carlossanlop This would be my fix. It gets rid of the Windows/Unix divergence and centralizes the workaround in a single place in Microsoft.NETCore.Native.Unix.targets |
This was referenced Aug 17, 2024
Closed
Closed
carlossanlop
approved these changes
Aug 19, 2024
carlossanlop
left a comment
carlossanlop
left a comment
Contributor
There was a problem hiding this comment.
I'll trigger some extra azp runs to confirm nothing breaks.
If it all looks good, we will need get it backported to release/9.0.
Contributor
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run runtime-community |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
The failures in outerloop runs are unrelated. |
Member
Author
|
/backport to release/9.0-rc1 |
Contributor
|
Started backporting to release/9.0-rc1: https://github.com/dotnet/runtime/actions/runs/10463283625 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106566