JIT: update simd base type when combining simd nodes for bitwise ops#106510
Merged
Conversation
If we merge two simd for bitwise ops (eg creating an AndNot), make sure to use the simd base type of the parent (And) node when specializing the operator. Fixes dotnet#106478.
ghost
added
the
area-CodeGen-coreclr
Member
Author
|
@tannergooding PTAL |
tannergooding
approved these changes
Aug 15, 2024
This was referenced Aug 16, 2024
Member
Author
|
/backport to release/9.0-rc1 |
Contributor
|
Started backporting to release/9.0-rc1: https://github.com/dotnet/runtime/actions/runs/10413532292 |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we merge two simd for bitwise ops (eg creating an AndNot), make sure to use the simd base type of the parent (And) node when specializing the operator.
Fixes #106478.