Add missing delegating/override method in TlsStream#106362
Merged
Merged
Conversation
ghost
added
the
MihaZupan
approved these changes
Aug 13, 2024
MihaZupan
left a comment
MihaZupan
left a comment
Member
There was a problem hiding this comment.
Is it feasible to extend our tests to cover this case?
Member
Author
Maybe, but I think it's not worth the investment. I would rather see TlsStream removed altogether to prevent similar bugs in the future, but that will have to wait till .NET 10. |
rokonec
approved these changes
Aug 13, 2024
wfurt
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99276.