Skip to content

Add missing xml docs for System.Numerics#106290

Merged
tannergooding merged 2 commits into
dotnet:mainfrom
tannergooding:fix-88570
Aug 14, 2024
Merged

Add missing xml docs for System.Numerics#106290
tannergooding merged 2 commits into
dotnet:mainfrom
tannergooding:fix-88570

Conversation

@tannergooding

Copy link
Copy Markdown
Member

This resolves #88570

@tannergooding

Copy link
Copy Markdown
Member Author

CC. @carlossanlop

This doesn't handle M:System.Numerics.INumberBase1.TryFormat(System.Span{System.Byte},System.Int32@,System.ReadOnlySpan{System.Char},System.IFormatProvider) as that API is explicitly implemented and so is not public API surface for the type. I expect the tool doesn't have the same tooling for explicitly implemented interface members on an interface as it does for a regular class.

@tannergooding

Copy link
Copy Markdown
Member Author

CC. @gewarren for review on the wording.

I copied most of it from existing docs

…OrderIeee754Comparer.cs

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@tannergooding tannergooding reopened this Aug 14, 2024
@tannergooding tannergooding merged commit aac99ee into dotnet:main Aug 14, 2024
@tannergooding tannergooding deleted the fix-88570 branch August 14, 2024 09:56
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port System.Numerics documentation for .NET 8.0 APIs

2 participants