Skip to content

Revert compile-native.proj to use local props#104072

Merged
MichalStrehovsky merged 2 commits into
dotnet:mainfrom
am11:patch-1
Jun 27, 2024
Merged

Revert compile-native.proj to use local props#104072
MichalStrehovsky merged 2 commits into
dotnet:mainfrom
am11:patch-1

Conversation

@am11

@am11 am11 commented Jun 27, 2024

Copy link
Copy Markdown
Member

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Jun 27, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky MichalStrehovsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@am11

am11 commented Jun 27, 2024

Copy link
Copy Markdown
Member Author

cdac should now be exactly as isolated as before. Let it do it's own thing until we figure out where the race is coming from. 😅

@am11

am11 commented Jun 27, 2024

Copy link
Copy Markdown
Member Author

@MichalStrehovsky an alternative is to merge #103375 instead. It simplifies it a bit, but I am not sure if it will fix the race condition. Only one way to find out. 😅

@MichalStrehovsky

Copy link
Copy Markdown
Member

My risk tolerance goes down with every day that we didn't have a usable product build. And we're on day 3 now.

I don't see that change changing things in terms of restore, so I'm not too optimistic it would fix things.

@am11

am11 commented Jun 27, 2024

Copy link
Copy Markdown
Member Author

np, I'll try to investigate it locally. Opened #104077.

@MichalStrehovsky

Copy link
Copy Markdown
Member

/ba-g unblocking official builds and SDK repo build flow. test runs will not find anything since this is not tested anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants