Remove Explicit System.Reflection.Metadata reference#4743
Merged
LoopedBard3 merged 1 commit intodotnet:mainfrom Mar 3, 2025
Merged
Remove Explicit System.Reflection.Metadata reference#4743LoopedBard3 merged 1 commit intodotnet:mainfrom
LoopedBard3 merged 1 commit intodotnet:mainfrom
Conversation
LoopedBard3
added
bug
LoopedBard3
changed the title
ghost
previously approved these changes
Mar 3, 2025
…ing a NU1510 warning which we treat as an error. It is not necessary to explicitly reference it as it seems to be an in-band package.
LoopedBard3
force-pushed
the
FixSystemReflectionError
branch
from
f474a44 to
f7a96e7
Compare
DrewScoggins
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove System.Reflection.Metadata explicit reference as it is triggering a NU1510 warning which we treat as an error. It is not necessary to explicitly reference it as it seems to be an in-band package. I tested this locally and it fixed the error on net10, net9 doesn't seem to hit the error either way, and it doesn't seem to break net8.
Fixes an issue caused by: #4699, although for whatever reason the CI did not fail, likely due to a coinciding update that made this an actual warning as it was recently added: https://github.com/NuGet/docs.microsoft.com-nuget/blob/main/docs/reference/errors-and-warnings/NU1510.md.