[msbuild] Add a GetMinimumOSVersion target that reads the app manifest and outputs the MinimumOSVersion.#8858
Merged
Conversation
…t and outputs the MinimumOSVersion. This makes it possible for several other tasks to take the MinimumOSVersion as direct input, instead of the app manifest's path. Previously the app manifest (Info.plist) was loaded and parsed in each task, slightly differently in each place, and in addition there are differences between macOS and other platforms, which made it even worse. This code refactoring also made it possible to remove an error code which wasn't necessary anymore. This task also computes the default MinimumOSVersion if none is specified in the app manifest. There is one breaking change: a library project could previously specify an inexistent Info.plist, and it would build fine. This will now result in a "Error loading 'Info.plist': File not found" error. This is trivial to fix: just remove the Info.plist from the project file (or an alternative solution could be to condition the inclusion of the Info.plist in the project file on the existence of the Info.plist). New commits in xamarin/Xamarin.MacDev: * dotnet/macios-devtools@a1bc6f3 [Xamarin.MacDev] Split IAppleSdkVersion.TryParse in two methods. (dotnet#73) Diff: https://github.com/xamarin/Xamarin.MacDev/compare/45c5a680e20a209ac846a32e0f2f0f83e843ab76..a1bc6f39b3efe5d817c60d78eaff3f4c2de720ea
chamons
approved these changes
Jun 15, 2020
spouliot
approved these changes
Jun 15, 2020
Contributor
|
Build success |
mandel-macaque
approved these changes
Jun 15, 2020
emaf
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible for several other tasks to take the MinimumOSVersion as
direct input, instead of the app manifest's path. Previously the app manifest
(Info.plist) was loaded and parsed in each task, slightly differently in each
place, and in addition there are differences between macOS and other
platforms, which made it even worse. This code refactoring also made it
possible to remove an error code which wasn't necessary anymore.
This task also computes the default MinimumOSVersion if none is specified in
the app manifest.
There is one breaking change: a library project could previously specify an
inexistent Info.plist, and it would build fine. This will now result in a
"Error loading 'Info.plist': File not found" error. This is trivial to fix:
just remove the Info.plist from the project file (or an alternative solution
could be to condition the inclusion of the Info.plist in the project file on
the existence of the Info.plist).
New commits in xamarin/Xamarin.MacDev:
Diff: https://github.com/xamarin/Xamarin.MacDev/compare/45c5a680e20a209ac846a32e0f2f0f83e843ab76..a1bc6f39b3efe5d817c60d78eaff3f4c2de720ea