Bump Xamarin.MacDev.#8059
Merged
Merged
Conversation
New commits in xamarin/Xamarin.MacDev: * dotnet/macios-devtools@a0a11af Adjust SDK validation to allow tools/bin and not allow usr/bin. (dotnet#71) * dotnet/macios-devtools@e21e1aa Accept 'tools/buildinfo' as an alternative path to 'buildinfo' due to an nuget bug. (dotnet#70) * dotnet/macios-devtools@ce24236 Don't look in /Developer/MonoTouch anymore, there's nothing there. (dotnet#69) Diff: https://github.com/xamarin/Xamarin.MacDev/compare/210c664e56117d3a1a7f6dd002109eb444dbdc17..a0a11aff271565bbaba029e5e428a0b9c2ca0e37
spouliot
approved these changes
Mar 6, 2020
Contributor
|
Build failure Test results2 tests failed, 85 tests passed.Failed tests
|
MonoTouchSdk ends up a bit confused when giving it an Sdk directory that isn't a real Sdk directory, and then assuming that properties that return Sdk paths won't throw exceptions. Fix this by giving MonoTouchSdk a better fake Sdk directory (which MonoTouchSdk detects as a real Sdk directory), and thus those previously mentioned properties will return true fake values instead of throwing exceptions.
rolfbjarne
requested review from
VincentDondain,
chamons,
emaf,
jstedfast and
kzu
as code owners
Contributor
|
Build success |
dalexsoto
approved these changes
Mar 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New commits in xamarin/Xamarin.MacDev:
Diff: https://github.com/xamarin/Xamarin.MacDev/compare/210c664e56117d3a1a7f6dd002109eb444dbdc17..a0a11aff271565bbaba029e5e428a0b9c2ca0e37