Skip to content

[release/6.0.1xx-preview7] [dotnet] Add support for implicit namespace imports. Fixes #12084.#12196

Merged
rolfbjarne merged 2 commits into
dotnet:release/6.0.1xx-preview7from
vs-mobiletools-engineering-service2:backport-pr-12173-to-release/6.0.1xx-preview7
Jul 23, 2021
Merged

[release/6.0.1xx-preview7] [dotnet] Add support for implicit namespace imports. Fixes #12084.#12196
rolfbjarne merged 2 commits into
dotnet:release/6.0.1xx-preview7from
vs-mobiletools-engineering-service2:backport-pr-12173-to-release/6.0.1xx-preview7

Conversation

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

Also update our templates to remove any using statements for implicitly imported
namespaces.

Fixes #12084.

Backport of #12173

Also update our templates to remove any using statements for implicitly imported
namespaces.

Fixes dotnet#12084.
…ing type conflict.

Fixes these errors:

    xamarin-macios/tests/monotouch-test/ImageIO/MutableImageMetadataTest.cs(54,54): error CS0104: 'CGImageProperties' is an ambiguous reference between 'CoreGraphics.CGImageProperties' and 'ImageIO.CGImageProperties'
    xamarin-macios/tests/monotouch-test/ImageIO/MutableImageMetadataTest.cs(54,88): error CS0104: 'CGImageProperties' is an ambiguous reference between 'CoreGraphics.CGImageProperties' and 'ImageIO.CGImageProperties'
    xamarin-macios/tests/monotouch-test/ImageIO/ImageMetadataTest.cs(40,54): error CS0104: 'CGImageProperties' is an ambiguous reference between 'CoreGraphics.CGImageProperties' and 'ImageIO.CGImageProperties'
    xamarin-macios/tests/monotouch-test/ImageIO/ImageMetadataTest.cs(40,88): error CS0104: 'CGImageProperties' is an ambiguous reference between 'CoreGraphics.CGImageProperties' and 'ImageIO.CGImageProperties'
@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 111 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2626 Passed: 2487 Inconclusive: 35 Failed: 2 Ignored: 137)

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 49c8ffc into ad40441

@rolfbjarne
Copy link
Copy Markdown
Member

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2471).

@rolfbjarne rolfbjarne merged commit f4e2140 into dotnet:release/6.0.1xx-preview7 Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants