Ensure rzc.dll and PresentationBuildTasks.dll are signed#8132
Merged
Conversation
Member
Author
|
I've sent mail, but can confirm internally these are now properly signed. |
sfoslund
approved these changes
Aug 11, 2020
sfoslund
left a comment
sfoslund
left a comment
Member
There was a problem hiding this comment.
Has this been checked in to master as well?
Member
Author
|
@sfoslund I'm going to check this into master shortly. Preview8 is the priority to unblock VS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK DLLs are crossgen'd during the installer build and then resigned. Two files are currently not being picked up by the existing globs: rzc.dll (this is part of the Razor SDK) and PresentationBuildTasks.dll (windows desktop).
The unsigned files are blocking the insertion into VS.