[release/5.0.1xx-preview8] Port Microsoft.DotNet.Sdk.Internal fixes from master#8105
Merged
Anipik merged 3 commits intoAug 5, 2020
Merged
Conversation
This reverts commit 7e76b75.
This reverts commit a7cf77d.
Set the asset manifest OS and change the name of the installers manifests. Currently arcade defaults to using OS-Platform as the asset manifest file name. Installer does a ton of building in docker containers, which ends up generating many overlapping names. This is a symptom and also likely hiding some non-determinsm. To fix, change the name of the blob asset manifest name to include a "-installers" suffix. Then alter the property names around a bit so that AssetManifestOS is set prior to publish.proj's publish target being run.
Anipik
approved these changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port trio of "real" fixes for the not-publishing/multi-publishing of Microsoft.DotNet.Sdk.Internal.