Fixup pools#8024
Merged
Merged
Conversation
Member
Author
|
/cc @agocke |
Member
Author
|
This needs to be ported to p8 too. |
dsplaisted
approved these changes
Jul 20, 2020
Comment on lines
+259
to
+264
| ${{ if eq(variables['System.TeamProject'], 'public') }}: | ||
| name: NetCorePublic-Pool | ||
| queue: buildpool.windows.10.amd64.vs2017.open | ||
| ${{ if eq(variables['System.TeamProject'], 'internal') }}: | ||
| name: NetCoreInternal-Pool | ||
| queue: buildpool.windows.10.amd64.vs2017 |
Member
There was a problem hiding this comment.
It looks like line 250 already ensures that the TeamProject is not public, so I don't think we need the separate conditions here.
Member
Author
There was a problem hiding this comment.
This pool doesn't need to be a helix build pool. It doesnt' download anything except a few asset manifest artifacts.
Member
|
FYI @wli3 |
agocke
approved these changes
Jul 20, 2020
mmitche
added a commit
to mmitche/installer
that referenced
this pull request
Jul 20, 2020
* Fixup pools and move to 2019 queues * Fixup queues * Revert publish build assets to hosted
mmitche
added a commit
that referenced
this pull request
Jul 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use internal pools on the internal project