Enabled source-building with mono runtime on any architecture.#14792
Enabled source-building with mono runtime on any architecture.#14792MichaelSimons merged 4 commits intodotnet:release/7.0.1xxfrom
Conversation
Adds an argument to the top-level build script to use the mono runtime, and sets the flags needed for the different repos to work with mono.
MichaelSimons
left a comment
MichaelSimons
left a comment
There was a problem hiding this comment.
These changes are too late for GA. I would be supportive of taking them in 7.0 servicing if the patches are backported/signed off by the product teams.
|
I can confirm this fixes source-build for me on s390x and ppc64le. |
|
I've synced the sdk patch with dotnet/sdk#28674, and it now prints an informative error message to the user the feature is not supported.
We need these patches for the mono-based builds. We can apply them ourselves if they are not included. Others will be interested in having them also, like for Alpine (dotnet/source-build#3020). cc @ayakael |
|
I'd also have armv6 be considered for mono build as well, as it is supported only on that backend. |
|
I'll re-target this PR to Like with PR that eliminates portable runtime, we can request backports once |
crummel
left a comment
crummel
left a comment
There was a problem hiding this comment.
This looks good to me so far, I'll check back in after the retargeting. Thanks Tom!
|
Close/Open to re-trigger CI. |
MichaelSimons
left a comment
MichaelSimons
left a comment
There was a problem hiding this comment.
LGTM w/one minor comment.
| echo " --run-smoke-test don't build; run smoke tests" | ||
| echo " --with-packages <dir> use the specified directory of previously-built packages" | ||
| echo " --with-sdk <dir> use the SDK in the specified directory for bootstrapping" | ||
| echo " --use-mono-runtime output uses the mono runtime" |
|
Update on 7.0 backports:
|
|
The sdk PR got the 7.0.3 milestone yesterday. We need to backport this PR to 7.0 too to complete the feature. |
|
@tmds - I'm not making the connection on what needs to be backported. The 7.0.3 milestone includes the 7.0.103 SDK. |
|
This PR (#14792) should be backported to 7.0. |
But it looks like this PR was merged into release/7.0.1xx. What am I missing? |
|
Oops, I thought this PR was targeting main. 😅 |
5 participants
Adds an argument to the top-level build script to use the mono runtime, and sets the flags needed for the different repos to work with mono.
This fixes dotnet/source-build#3076 and also enables building .NET on any architectures (including x64, and arm64) with mono runtime.
@crummel @MichaelSimons ptal
cc @uweigand @omajid @janani66