Feed back - remove some extraneous console logging#8365
Merged
Conversation
brettfo
approved these changes
Jan 28, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
T-Gro
pushed a commit
that referenced
this pull request
Jun 17, 2026
Port and adapt microsoft/testfx PR #8365 ("MSBuild quality review") to a gh-aw workflow for dotnet/fsharp. Runs weekly, audits the repo's .props / .targets / .Targets files for MSBuild authoring issues, files an issue with findings, and can open a draft PR for safe, low-risk fixes. F#-specific adaptations: - Phase 1 discovery rewritten for the fsharp layout: case-insensitive search (-iname) catches the capital-.Targets crown jewels (Microsoft.FSharp.Targets, Microsoft.Portable.FSharp.Targets); prioritizes the shipped F# SDK build logic in src/FSharp.Build, src/fsc, src/fsi and the vsintegration/shims; excludes .dotnet/ (the downloaded SDK), obj/bin/artifacts/packages. - Removed the nonexistent shared/reporting.md import; report template is inline. - Down-weighted the NuGet build/ rules (D-2 and all of E) that don't apply here (fsharp ships via the .NET SDK / FSharp.Build, not NuGet build/ folders) and emphasized Categories A, B, C, D-1/3/4/5. - House-style frontmatter: default copilot engine, network [defaults, dotnet], read-only permissions with safe-outputs for writes. Labels automation + Area-ProjectsAndBuild (both already exist in dotnet/fsharp). - Phase 6 build validation scoped (no full ./build.sh) to fit the 30-min timeout. Lock file compiled with gh aw v0.76.1, matching the repo's existing workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.