Fix ParallelCompilation property passing#19945
Merged
Merged
Conversation
Contributor
✅ No release notes required |
Contributor
Author
|
It looks that unlike Roslyn, we don't have dedicated integration tests around Fsc MSBuild task, letting bugs like this one slip through sometimes. |
github-actions
Bot
added
the
⚠️ Affects-Build-Infra
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
The problem is |
majocha
commented
Jun 14, 2026
github-actions
Bot
added
the
⚠️ Affects-Test-Tooling
Contributor
|
🔍 Tooling Safety Check — Affects-Build-Infra, Affects-Test-Tooling
|
T-Gro
approved these changes
Jun 16, 2026
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
Member
|
@majocha : https://github.com/dotnet/fsharp/tree/main/tests/fsharp/SDKTests/tests is something like "unit tests" for individual pieces of logic contained within our msbuild artifacts. |
This was referenced Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19935