Report FS3888 for generic attribute type abbreviations instead of FS0193#19915
Open
T-Gro wants to merge 6 commits into
Open
Report FS3888 for generic attribute type abbreviations instead of FS0193#19915T-Gro wants to merge 6 commits into
T-Gro wants to merge 6 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…7877) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
abonie
reviewed
Jun 17, 2026
| let tcref = tcrefOfAppTy g ty | ||
|
|
||
| if not tcref.TyparsNoRange.IsEmpty then | ||
| errorR(Error(FSComp.SR.tcGenericAttributesNotSupported(tcref.DisplayName), mAttr)) |
Member
There was a problem hiding this comment.
This calls errorR unconditionally, ignoring the canFail mode, seems like it might lead to duplicate diagnostics.
The test should perhaps assert more than just withErrorCode 3888 and check that there is only one error.
Member
Author
There was a problem hiding this comment.
Good catch, both addressed in 51056cd.
- The error path now honors
canFail: underIgnoreAllErrors/IgnoreMemberResoutionErrorit returns[], true(suppress + signal failure so the later report-all pass surfaces it once), and only emitserrorRunderReportAllErrors— mirroring the existing constructor-resolution handling a few lines below. No more duplicate FS3888. - The repro test now uses
withSingleDiagnosticasserting exactly one error with its full message and range.
…iagnostics Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Resolve FSComp.txt error-number collision: renumber the generic-attribute diagnostic tcGenericAttributesNotSupported from 3888 to 3890 (3888/3889 were taken by origin/main). Update its tests and release note to FS3890. Adapt the generic-attribute check to the removal of EntityRef.TyparsNoRange (now Typars). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7877