Keep parens around records in interpolated strings#18534
Merged
T-Gro merged 3 commits intoMay 12, 2025
Conversation
Contributor
❗ Release notes required
|
abonie
approved these changes
May 7, 2025
T-Gro
approved these changes
May 12, 2025
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
This was referenced Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keep parentheses around records and
seq-less sequence expressions in interpolated strings. Inspired by Fantoms breaks anonymous records in interpolated strings fsprojects/fantomas#3162.We could alternatively add spaces as part of the code fix, but I am leaning towards not doing more of that unless I someday get around to doing something more sophisticated as described in
SynExpr.shouldBeParenthesizedInContextsubtleties #16966.Checklist