Make [<CallerMemberName; Struct>] combination work#18444
Merged
psfinaki merged 3 commits intoApr 9, 2025
Merged
Conversation
Contributor
❗ Release notes required
|
…info-attributes-will-fails-in-type-check
abonie
approved these changes
Apr 9, 2025
psfinaki
approved these changes
Apr 9, 2025
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
This was referenced May 15, 2025
T-Gro
deleted the
18386-struct-optional-parameter-with-caller-info-attributes-will-fails-in-type-check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The combination of
[<CallerMemberName; Struct>]was not working correctly.Fixes #18386
After fixing the typecheck failure, this later lead to invalid IL (
Some xpassed toValueOptionexpecting methods).This has been rectified for all 3
Caller..enhancement attributes.