Skip to content

Graph typechecking issue fix when using global namespace.#17553

Merged
psfinaki merged 15 commits into
dotnet:mainfrom
vzarytovskii:graph-checking-issue
Aug 19, 2024
Merged

Graph typechecking issue fix when using global namespace.#17553
psfinaki merged 15 commits into
dotnet:mainfrom
vzarytovskii:graph-checking-issue

Conversation

@vzarytovskii

Copy link
Copy Markdown
Member

Test (and later fix) for the issue found in #17442

@vzarytovskii vzarytovskii requested a review from a team as a code owner August 16, 2024 17:22
@github-actions

github-actions Bot commented Aug 16, 2024

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@vzarytovskii

Copy link
Copy Markdown
Member Author

@nojaf I figured that we can skip global when transforming LongIdent to path.

Comment thread src/Compiler/Driver/GraphChecking/FileContentMapping.fs Outdated
Comment thread src/Compiler/Driver/GraphChecking/FileContentMapping.fs Outdated
Comment thread tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/Scenarios.fs

@nojaf nojaf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@psfinaki

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants