Skip to content

Default GraphBasedChecking, ParallelOptimization and ParallelIlxGen optimizations#17400

Closed
edgarfgp wants to merge 9 commits into
dotnet:mainfrom
edgarfgp:enable-some-more-optimizations
Closed

Default GraphBasedChecking, ParallelOptimization and ParallelIlxGen optimizations#17400
edgarfgp wants to merge 9 commits into
dotnet:mainfrom
edgarfgp:enable-some-more-optimizations

Conversation

@edgarfgp

@edgarfgp edgarfgp commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

Description

Enable by default:

  • GraphBasedChecking
  • ParallelOptimization
  • ParallelIlxGen

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions

Copy link
Copy Markdown
Contributor

Caution

Repository is on lockdown for maintenance, all merges are on hold.

@github-actions

github-actions Bot commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

Comment thread tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/CompilationTests.fs Outdated
@edgarfgp

edgarfgp commented Jul 10, 2024

Copy link
Copy Markdown
Contributor Author

@vzarytovskii @KevinRansom. I would like to propose enabling the described optimizations by default. I'm using Kevin's
Defaultrealsig PR as an example. Let me know your thoughts and any pointer is appreciated.

@vzarytovskii

Copy link
Copy Markdown
Member

Could you please mention in FCS changelog that we changed the defaults?

@edgarfgp

Copy link
Copy Markdown
Contributor Author

Could you please mention in FCS changelog that we changed the defaults?

Done. Not sure why the bot decided to put the No release notes required

}
}

.method public static int32 select1(class Match01/Test1 x) cil managed

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't look good, that it changed ordering. A potential determinism issue here

@@ -124,18 +116,12 @@
int32 V_3,
class [runtime]System.Collections.IComparer V_4,
int32 V_5,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also doesn't look good, unsure why baselines changed, ilx output should retain the same order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants