Skip to content

Enable Visualizer Support for F# in VS#17239

Merged
vzarytovskii merged 3 commits into
dotnet:mainfrom
mpeyrotc:dev/mapeyrot/enable_visualizers
May 25, 2024
Merged

Enable Visualizer Support for F# in VS#17239
vzarytovskii merged 3 commits into
dotnet:mainfrom
mpeyrotc:dev/mapeyrot/enable_visualizers

Conversation

@mpeyrotc

@mpeyrotc mpeyrotc commented May 24, 2024

Copy link
Copy Markdown
Contributor

Description

This PR addresses bug 361 from the VS Extensibility repo, where a customer is complaining about the lack of support of Custom Visualizers in VS for the F# language. I tested F#'s support of this scenario and did not notice any issues with it, so I feel it can be safely enabled for VS 2022. The only required change is to register the appropriate EE metric that gets consumed by VS to indicate the visualizers are supported.

Checklist

  • Test cases added Not tests were added since there was no change to the language itself.
  • Performance benchmarks added in case of performance changes. This change should have 0 performance impact on the language.
  • Release notes entry updated:

@mpeyrotc mpeyrotc requested a review from a team as a code owner May 24, 2024 00:32
@github-actions

Copy link
Copy Markdown
Contributor

✅ No release notes required

@KevinRansom KevinRansom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice,

thank you

@abelbraaksma

Copy link
Copy Markdown
Contributor

Even though it may look like a small change, the impact is massive! Thanks so much for this, and maybe you can update the release-notes anyway, so that people are aware this feature is coming their way? (or is there more that needs to be done here?)

@psfinaki psfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! @mpeyrotc since you've tested the scenario - if you have a minute - could you maybe record a quick demo of how things look like now? We can then probably promote this feature a bit :)

@smoothdeveloper

Copy link
Copy Markdown
Contributor

If the test/demo can confirm it works with a System.Data.DataTable, that would be great.

related issue: #13482

@mpeyrotc

Copy link
Copy Markdown
Contributor Author

Hello psfinaki, and smoothdeveloper! Here is a .gif showcasing the IEnumerable and DataTable Visualizers for a simple F# project.

F#

@smoothdeveloper

Copy link
Copy Markdown
Contributor

@mpeyrotc that rocks!

@abelbraaksma abelbraaksma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants