Skip to content

Remove some unnecessary code introduced in #16779#17154

Merged
psfinaki merged 2 commits into
dotnet:mainfrom
majocha:al-cleanup
May 16, 2024
Merged

Remove some unnecessary code introduced in #16779#17154
psfinaki merged 2 commits into
dotnet:mainfrom
majocha:al-cleanup

Conversation

@majocha

@majocha majocha commented May 16, 2024

Copy link
Copy Markdown
Contributor

Some cleanup following the AsyncLocal stuff.

This code is most probably unneeded, because this now happens in Async.RunImmediate.

@github-actions

github-actions Bot commented May 16, 2024

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@majocha majocha marked this pull request as ready for review May 16, 2024 10:03
@majocha majocha requested a review from a team as a code owner May 16, 2024 10:03
@majocha

majocha commented May 16, 2024

Copy link
Copy Markdown
Contributor Author

@psfinaki, just as you noticed in the review, this is duplication. If it's green, it can be safely removed.

I think release notes not needed.

@psfinaki psfinaki added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label May 16, 2024

@psfinaki psfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jakub :)

@psfinaki psfinaki enabled auto-merge (squash) May 16, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants