Skip to content

Completion: don't prevent getting items after record definition#16813

Merged
vzarytovskii merged 5 commits into
dotnet:mainfrom
auduchinok:completion-recdDefn
Mar 12, 2024
Merged

Completion: don't prevent getting items after record definition#16813
vzarytovskii merged 5 commits into
dotnet:mainfrom
auduchinok:completion-recdDefn

Conversation

@auduchinok

Copy link
Copy Markdown
Member

Fixes broken code completion after a record type declaration:

type R =
    { F: int }

{caret}

@auduchinok auduchinok requested a review from a team as a code owner March 5, 2024 14:24
@github-actions

github-actions Bot commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

Comment thread src/Compiler/Service/ServiceParsedInputOps.fs
@psfinaki

psfinaki commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki

psfinaki commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

Some tests for this? :)

As of now, I don't entirely understand what's broken and what's changing.

image

@majocha

majocha commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

@psfinaki , try with cursor outside or below of curly brackets after the declaration. However, once you start typing, completions do show up after one letter.

@auduchinok

Copy link
Copy Markdown
Member Author

As of now, I don't entirely understand what's broken and what's changing.

There're no F# symbols from FCS when pressing Ctrl+Space after the type decl:

Screenshot 2024-03-06 at 09 39 17

@psfinaki

psfinaki commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

Oh alright I see, thanks for pointing out.
Okay but still we should probably have some tests for it :-P

@vzarytovskii vzarytovskii enabled auto-merge (squash) March 12, 2024 09:52
@vzarytovskii

Copy link
Copy Markdown
Member

Will auto-merge as soon as comments are resolved

@vzarytovskii vzarytovskii merged commit be658c5 into dotnet:main Mar 12, 2024
@auduchinok auduchinok deleted the completion-recdDefn branch March 12, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants