Skip to content

Filter diagnostics for errors.#16622

Merged
psfinaki merged 2 commits into
dotnet:mainfrom
nojaf:filter-errors
Jan 31, 2024
Merged

Filter diagnostics for errors.#16622
psfinaki merged 2 commits into
dotnet:mainfrom
nojaf:filter-errors

Conversation

@nojaf

@nojaf nojaf commented Jan 31, 2024

Copy link
Copy Markdown
Contributor

Description

My project had a lot of warnings and info in the diagnostics.
I believe we can safely filter these out.

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@nojaf nojaf requested a review from a team as a code owner January 31, 2024 11:07
@nojaf nojaf requested a review from 0101 January 31, 2024 11:07
@github-actions

Copy link
Copy Markdown
Contributor

✅ No release notes required

@psfinaki

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

Comment thread tests/FSharp.Test.Utilities/ProjectGeneration.fs
@nojaf

nojaf commented Jan 31, 2024

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 16622 in repo dotnet/fsharp

@nojaf

nojaf commented Jan 31, 2024

Copy link
Copy Markdown
Contributor Author

Some CompilerService.AsyncMemoize tests are failing. They run fine locally, pretty sure this is unrelated.

@psfinaki

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@0101

0101 commented Jan 31, 2024

Copy link
Copy Markdown
Contributor

Some CompilerService.AsyncMemoize tests are failing. They run fine locally, pretty sure this is unrelated.

Yeah they are flaky. The fix for that is here: #16612

@psfinaki psfinaki enabled auto-merge (squash) January 31, 2024 15:25
@psfinaki psfinaki merged commit af4e7a1 into dotnet:main Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants