Skip to content

Parens: Keep parens for problematic exprs in $"{(…):N0}", $"{(…),-3}", etc.#16578

Merged
psfinaki merged 6 commits into
dotnet:mainfrom
brianrourkeboll:parens-interpolated-strings-with-qualifiers
Jan 26, 2024
Merged

Parens: Keep parens for problematic exprs in $"{(…):N0}", $"{(…),-3}", etc.#16578
psfinaki merged 6 commits into
dotnet:mainfrom
brianrourkeboll:parens-interpolated-strings-with-qualifiers

Conversation

@brianrourkeboll

@brianrourkeboll brianrourkeboll commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

Description

Another followup to #16079.

  • Keep parens for problematic exprs (if, match, etc.) in $"{(…):N0}", $"{(…),-3}", etc.

Checklist

  • Test cases added.
  • Release notes entry updated.

@github-actions

github-actions Bot commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

@brianrourkeboll brianrourkeboll marked this pull request as ready for review January 24, 2024 00:16
@brianrourkeboll brianrourkeboll requested a review from a team as a code owner January 24, 2024 00:16

@psfinaki psfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread src/Compiler/Service/SynExpr.fs
@brianrourkeboll

Copy link
Copy Markdown
Contributor Author

@psfinaki this just needs an azp rerun.

@psfinaki

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki

Copy link
Copy Markdown
Contributor

@brianrourkeboll FYI a small lif#hack: you can force it by closing and reopening the PR :)

@psfinaki psfinaki merged commit 9ae94bb into dotnet:main Jan 26, 2024
@brianrourkeboll brianrourkeboll deleted the parens-interpolated-strings-with-qualifiers branch January 26, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants