Skip to content

More VS cleanup#15954

Merged
T-Gro merged 25 commits into
dotnet:mainfrom
vzarytovskii:more-cancellable-tasks3
Oct 10, 2023
Merged

More VS cleanup#15954
T-Gro merged 25 commits into
dotnet:mainfrom
vzarytovskii:more-cancellable-tasks3

Conversation

@vzarytovskii

@vzarytovskii vzarytovskii commented Sep 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Member
  1. Option -> ValueOption in some places
  2. More cancellable tasks
  3. Removed creating asyncs + running in parallel on lightweight CPU bound AIO find operations
  4. Something else.

VSIX: https://1drv.ms/u/s!AiT31MwroM_3lfUYVfV8H3l14MZfpg?e=wxpUdd

vzarytovskii
vzarytovskii commented Sep 8, 2023
View reviewed changes
Comment thread vsintegration/src/FSharp.Editor/Commands/XmlDocCommandService.fs
psfinaki
psfinaki reviewed Sep 12, 2023
View reviewed changes
Comment thread vsintegration/src/FSharp.Editor/Navigation/NavigateToSearchService.fs Outdated
psfinaki
psfinaki reviewed Sep 12, 2023
View reviewed changes
Comment thread vsintegration/src/FSharp.Editor/Common/CodeAnalysisExtensions.fs
psfinaki
psfinaki reviewed Sep 12, 2023
View reviewed changes
Comment thread vsintegration/src/FSharp.Editor/Navigation/GoToDefinition.fs
psfinaki
psfinaki reviewed Sep 12, 2023
View reviewed changes
Comment thread vsintegration/src/FSharp.Editor/Classification/ClassificationService.fs Outdated
psfinaki
psfinaki reviewed Sep 12, 2023
View reviewed changes
Comment thread vsintegration/src/FSharp.Editor/LanguageService/FSharpAnalysisSaveFileCommandHandler.fs Outdated
psfinaki
psfinaki reviewed Sep 12, 2023
View reviewed changes
Comment thread vsintegration/src/FSharp.Editor/LanguageService/FSharpAnalysisSaveFileCommandHandler.fs Outdated
@vzarytovskii

vzarytovskii commented Sep 12, 2023

Copy link
Copy Markdown
Member Author

Right now, going to external definition deadlocks on projectContextFactory.CreateProjectContext(projFilePath, projInfo.Id.ToString()), I have not yet figured out why (probably because inside it does the jtf.Run).

@vzarytovskii

vzarytovskii commented Sep 20, 2023

Copy link
Copy Markdown
Member Author

/run fantomas

@github-actions
Automated command ran: fantomas
bd4baba 
  Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 20, 2023

Copy link
Copy Markdown
Contributor

Ran fantomas: https://github.com/dotnet/fsharp/actions/runs/6249185296

0101
0101 reviewed Oct 9, 2023
View reviewed changes
Comment thread vsintegration/src/FSharp.Editor/CodeFixes/AddOpenCodeFixProvider.fs Outdated
@vzarytovskii vzarytovskii marked this pull request as ready for review October 9, 2023 13:36
@vzarytovskii vzarytovskii requested a review from a team as a code owner October 9, 2023 13:36
@vzarytovskii

vzarytovskii commented Oct 9, 2023

Copy link
Copy Markdown
Member Author

I'd like to merge it.

@vzarytovskii

vzarytovskii commented Oct 9, 2023

Copy link
Copy Markdown
Member Author

/run fantomas

@github-actions
Automated command ran: fantomas
5130812 
  Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 9, 2023

Copy link
Copy Markdown
Contributor

Ran fantomas: https://github.com/dotnet/fsharp/actions/runs/6457658743

psfinaki
psfinaki approved these changes Oct 9, 2023
View reviewed changes
Comment thread vsintegration/src/FSharp.Editor/Classification/ClassificationService.fs
@vzarytovskii

vzarytovskii commented Oct 9, 2023

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Oct 9, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@T-Gro T-Gro merged commit 5b94f74 into dotnet:main Oct 10, 2023
@allisonchou allisonchou mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+2 more reviewers

@0101 0101 0101 approved these changes

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vzarytovskii @0101 @psfinaki @T-Gro