Skip to content

Moved Pattern Matching Test from FSharpQA to ComponentTests#15758

Merged
vzarytovskii merged 7 commits into
dotnet:mainfrom
edgarfgp:move-test-from-fsharp-qa-to-component
Aug 13, 2023
Merged

Moved Pattern Matching Test from FSharpQA to ComponentTests#15758
vzarytovskii merged 7 commits into
dotnet:mainfrom
edgarfgp:move-test-from-fsharp-qa-to-component

Conversation

@edgarfgp

@edgarfgp edgarfgp commented Aug 7, 2023

Copy link
Copy Markdown
Contributor
  • Check that all assertions are correct
  • Remove the old tests once the team and CI are happy

This will help with #15733 as I can run the pattern matching tests easily

@edgarfgp edgarfgp requested a review from a team as a code owner August 7, 2023 19:20
@KevinRansom

Copy link
Copy Markdown
Contributor

Nice!!!!!!

Comment thread tests/FSharp.Compiler.ComponentTests/Conformance/PatternMatching/And/And.fs Outdated
@psfinaki

psfinaki commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Thanks Edgar, thanks for investing in our testing life :)
Hopefully git will handle moved files so that we can review it more or less thoroughly.

@edgarfgp

edgarfgp commented Aug 8, 2023

Copy link
Copy Markdown
Contributor Author

Thanks Edgar, thanks for investing in our testing life :) Hopefully git will handle moved files so that we can review it more or less thoroughly.

Removed the old test. Let's see how it handles the moved files.

@vzarytovskii vzarytovskii enabled auto-merge (squash) August 11, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants