Filter completions when dotting into a type or module in a pattern#15706
Merged
Conversation
Contributor
Author
|
Also, what do you think about about classifying IL constants the same way as F# literals? The screenshot below is from a popular .NET language.
|
abonie
approved these changes
Jul 31, 2023
psfinaki
approved these changes
Jul 31, 2023
psfinaki
left a comment
psfinaki
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this is useful!
Contributor
I am on the fence here, maybe you can submit a separate PR to bring this into a discussion? |
Member
I don't see why not, after all x-project solutions are not unpopular, amirite? |
T-Gro
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing completions that are not usable in a pattern when dotting into a type, module or namespace - methods, properties, values that are not literals and fields that are not constants.
Before
After
(The 2nd screenshot contains extra members because of TFM difference)