Skip to content

More accurate range for FS0053: Discriminated union cases and exception labels must be uppercase identifiers#15545

Merged
psfinaki merged 2 commits into
dotnet:mainfrom
edgarfgp:use-more-accurate-range-for-fs0053
Jul 4, 2023
Merged

More accurate range for FS0053: Discriminated union cases and exception labels must be uppercase identifiers#15545
psfinaki merged 2 commits into
dotnet:mainfrom
edgarfgp:use-more-accurate-range-for-fs0053

Conversation

@edgarfgp

@edgarfgp edgarfgp commented Jul 4, 2023

Copy link
Copy Markdown
Contributor

Fixes #15507

Update: also fixes #15509

@edgarfgp edgarfgp marked this pull request as ready for review July 4, 2023 16:24
@edgarfgp edgarfgp requested a review from a team as a code owner July 4, 2023 16:24
@edgarfgp

edgarfgp commented Jul 4, 2023

Copy link
Copy Markdown
Contributor Author

This is ready

@psfinaki psfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two birds with one stone!

Thanks @edgarfgp, you've made my day :)

@psfinaki psfinaki enabled auto-merge (squash) July 4, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Implement ProposeUppercaseLabel code fix for lowercase exceptions Probably inconsistent error range for FS0053

3 participants