Remove unused code#14589
Merged
Merged
Conversation
KevinRansom
suggested changes
Jan 11, 2023
KevinRansom
left a comment
KevinRansom
left a comment
Contributor
There was a problem hiding this comment.
I love this change, but I want to understand whether the reordering of the baseline file is benign.
Also there is too much churn in that file to see whether something interesting was removed.
So if we can hold off on merging for a short while.
Member
|
I want to nominate this for PR of the year. |
Contributor
|
I'm gonna do the baselines for this differently, so the big delta here is fine for now. |
KevinRansom
approved these changes
Jan 12, 2023
KevinRansom
left a comment
KevinRansom
left a comment
Contributor
There was a problem hiding this comment.
Now I think I understand what is going on with the baseline.
nojaf
commented
Jan 12, 2023
T-Gro
reviewed
Jan 12, 2023
T-Gro
reviewed
Jan 12, 2023
T-Gro
reviewed
Jan 12, 2023
T-Gro
reviewed
Jan 12, 2023
Contributor
Author
|
@T-Gro I've addressed all the remarks. This one is good to go. |
T-Gro
approved these changes
Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In light of #14567, I believe to have found some code that is unused.
These are top-level functions that are unused in the file they are defined and are not part of the signature.
In some cases, I did update the signature file. (For example in
Result.toSeqin FSharp.Core, because the value was missing insrc/FSharp.Core/result.fsiit was considered unused).And in
sformat.fsI did shuffle some functions a bit because depending on theCOMPILERdefine value the code was considered to be unused or not. This file is used both inFCSandFSharp.Core.