Warning or error is raised when consuming IL Event with an Obsolete attribute#14006
Merged
vzarytovskii merged 5 commits intoOct 4, 2022
Merged
Warning or error is raised when consuming IL Event with an Obsolete attribute#14006vzarytovskii merged 5 commits into
vzarytovskii merged 5 commits into
Conversation
… Obsolete attribute is raised
edgarfgp
changed the title
T-Gro
approved these changes
Oct 3, 2022
vzarytovskii
approved these changes
Oct 4, 2022
vzarytovskii
reviewed
Oct 4, 2022
vzarytovskii
requested changes
Oct 4, 2022
vzarytovskii
left a comment
vzarytovskii
left a comment
Member
There was a problem hiding this comment.
Just small comment on matching.
As a rule of thumb, we probably shouldn't ever match on any DUs from infos.
Member
I am planning more encapsulation around infos, Don lure me into this and I think it makes sense. |
vzarytovskii
approved these changes
Oct 4, 2022
vzarytovskii
approved these changes
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a BUG mentioned on #13511 (comment)