Skip to content

Correct SynAttribute range#13998

Merged
vzarytovskii merged 10 commits into
dotnet:mainfrom
nojaf:syn-attribute-range
Oct 6, 2022
Merged

Correct SynAttribute range#13998
vzarytovskii merged 10 commits into
dotnet:mainfrom
nojaf:syn-attribute-range

Conversation

@nojaf

@nojaf nojaf commented Sep 28, 2022

Copy link
Copy Markdown
Contributor

Fixes #13983

@auduchinok auduchinok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nojaf Thanks for fixing it :)

Comment thread src/Compiler/pars.fsy Outdated
@nojaf nojaf force-pushed the syn-attribute-range branch from 30950b2 to 310cffd Compare September 28, 2022 09:05
@nojaf

nojaf commented Sep 29, 2022

Copy link
Copy Markdown
Contributor Author

@dsyme ready for review 😊.

@nojaf

nojaf commented Oct 6, 2022

Copy link
Copy Markdown
Contributor Author

@vzarytovskii can we have this one in main as well, please?

@vzarytovskii vzarytovskii merged commit e389d77 into dotnet:main Oct 6, 2022
@nojaf

nojaf commented Oct 6, 2022

Copy link
Copy Markdown
Contributor Author

Many thanks!

@nojaf nojaf deleted the syn-attribute-range branch February 9, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The range of SynAttribute looks incorrect.

4 participants