Skip to content

FSharp.Core examples added to doc-comments#12211

Merged
dsyme merged 10 commits into
dotnet:mainfrom
sgoguen:dev/fsharp-core-examples
Oct 11, 2021
Merged

FSharp.Core examples added to doc-comments#12211
dsyme merged 10 commits into
dotnet:mainfrom
sgoguen:dev/fsharp-core-examples

Conversation

@sgoguen

@sgoguen sgoguen commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

No description provided.

* Arithmetic
* Bitwise Operators
* Comparison Operators
* Composition and Pipeline Operators
* defaultArgs
* raise, reraise, Failure
* Tuple fst, snd
@dnfadmin

dnfadmin commented Oct 5, 2021

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@dsyme dsyme left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I've left some initial comments - I'll review again when you're ready

Comment thread src/fsharp/FSharp.Core/prim-types.fsi Outdated
Comment thread src/fsharp/FSharp.Core/prim-types.fsi Outdated
Comment thread src/fsharp/FSharp.Core/prim-types.fsi Outdated
Comment thread src/fsharp/FSharp.Core/prim-types.fsi Outdated
Comment thread src/fsharp/FSharp.Core/prim-types.fsi Outdated
Comment thread src/fsharp/FSharp.Core/prim-types.fsi Outdated
Comment thread src/fsharp/FSharp.Core/prim-types.fsi Outdated
Comment thread src/fsharp/FSharp.Core/prim-types.fsi Outdated
Comment thread src/fsharp/FSharp.Core/prim-types.fsi Outdated
Comment thread src/fsharp/FSharp.Core/prim-types.fsi Outdated
@dsyme

dsyme commented Oct 11, 2021

Copy link
Copy Markdown
Contributor

@sgoguen I've updated your branch with a few fixes

@dsyme dsyme enabled auto-merge (squash) October 11, 2021 13:09
@dsyme dsyme disabled auto-merge October 11, 2021 13:18
@dsyme

dsyme commented Oct 11, 2021

Copy link
Copy Markdown
Contributor

@sgougen I will merge this - some examples remain to be filled in but it is still in decent shape. We can fill those in next

@dsyme

dsyme commented Oct 11, 2021

Copy link
Copy Markdown
Contributor

@sgoguen Thank you so much for this contribution, and let's continue #12124 to the finishing line!

@dsyme dsyme merged commit 77ef177 into dotnet:main Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants