fix boxing promotion for locally mutable values#11687
Merged
Merged
Conversation
Contributor
Author
|
@kerams This contains some other cleanup to your PR which will change generated names etc. |
added 4 commits
June 17, 2021 14:32
Contributor
Author
|
@kerams I worked out the thing I just mentioned, was difference between DisplayName and LogicalName. Best to use LogicalName in anything related to optimiziation |
brettfo
approved these changes
Jun 17, 2021
Member
|
Some of the changes (in tests) may be conflicting when #11690 is merged and vice versa. |
This was referenced Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should prevent us doing the reversion in #11686 and instead address the issue noted with the PR