Type checking is cancelled on parsing errors in the compiler compilations

[auduchinok]

While adding tests to #18311, I've noticed two things about reporting type checker errors:

• Type checker errors are not reported in the component tests when there're any parsing errors

  • This makes it less suitable for testing the compiler service, since the errors are actually produced and reported there. This behavior is, however, inline with the actual compiler (not the service), so it's not clear what is the desired option here

• The compiler stops when encountering syntax errors. It makes failing builds fail faster, but is it the behavior that we want? I.e. when there's a parser error, it seems that unrelated type checker errors are not going to be reported. I think reporting all known errors, like we do in the service, would be much more helpful with fixing these errors.

[Martin521]

Regarding the first item:
There is ParseAndTypeCheck, returning both parse and type check errors.
It seems that TypeCheck is meant for cases where you are only interested in tc diagnostics. But TBH I am not sure why it even exists.
There are just way too many functions in CompilerAssert, service, FSharpParseFileResults, FSharpCheckerResults, BackgroundCompiler etc.