Wrong symbol use is reported for custom operation overloads by `GetAllUsesOfAllSymbolsInFile`

[auduchinok]

An extraction of an issue from #11612 (comment).

When there're multiple overloads of a custom operation, a wrong overload item is reported to the sink.

type FooBuilder() =
    member _.Yield _ = 1

    [<CustomOperation "create">]
    member _.Create(i1: int, s: string, i2: int) = 1

    [<CustomOperation "create">]
    member _.Create(i: int, s1: string, s2: string) = 1

FooBuilder() {
    create "" 1
    create "" ""
}

[brianrourkeboll]

Thanks for reporting this—I’ve been meaning to for months :)

[brianrourkeboll]

At a glance, it looks like this wasn't updated in #9400 and is just grabbing the first method info in this list (apparently equivalent to the last overload):

fsharp/src/Compiler/Checking/Expressions/CheckComputationExpressions.fs

Lines 2491 to 2503 in 767b5ec

	| OptionalSequential(CustomOperationClause ceenv (nm, opDatas, opExpr, mClause, optionalIntoPat), optionalCont) ->
	let opName, _, _, _, _, _, _, _, methInfo = opDatas[0]
	let isLikeZip = customOperationIsLikeZip ceenv nm
	let isLikeJoin = customOperationIsLikeJoin ceenv nm
	let isLikeGroupJoin = customOperationIsLikeZip ceenv nm
	// Record the resolution of the custom operation for posterity
	let item =
	Item.CustomOperation(opName, (fun () -> customOpUsageText ceenv nm), Some methInfo)

That is, the MethInfo used here isn't necessarily the actual MethInfo that is resolved when the synthetic method call (created here via mkSynCall) is typechecked later:

fsharp/src/Compiler/Checking/Expressions/CheckComputationExpressions.fs

Lines 2554 to 2567 in 767b5ec

	mkSynCall methInfo.DisplayName mClause (dataCompPrior :: args) ceenv.builderValName
	else
	let expectedArgCount = defaultArg expectedArgCount 0
	errorR (
	Error(FSComp.SR.tcCustomOperationHasIncorrectArgCount (nm.idText, expectedArgCount, args.Length), nm.idRange)
	)
	mkSynCall
	methInfo.DisplayName
	mClause
	([ dataCompPrior ]
	@ List.init expectedArgCount (fun i -> arbExpr ("_arg" + string i, mClause)))
	ceenv.builderValName

The challenge will be to somehow move the recording of the symbol usage until the actual overload has been resolved.