[release/8.0] Visit inside InlineQueryRootExpression in nav expansion#32467
Merged
Conversation
ajcvickers
approved these changes
Dec 1, 2023
Member
|
Note that the branch is currently closed. |
Member
|
@roji can you resolve the merge conflicts? Then I can merge |
Fixes dotnet#32331 (cherry picked from commit 50a8ae5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32331, backports #32460.
Description
As part of the primitive collection work for EF 8, the new InlineCollectionQueryRoot expression type was introduced to represent collections which are inline in the LINQ query (e.g.
Where(b => new[] { 1, 3 }.Where(...)). However, our navigation expansion visitor, which is responsible for processing navigations, was not modified to visit inside this new expression type; as a result, navigations inside subqueries within InlineCollectionQueryRoot do not work.Customer impact
Queries which include navigations inside an inline collection fail to execute, e.g.:
Such queries used to work in 7.0, if the code in question was in the top-level Select (and got client-evaluated).
How found
Customers reported on 8.0
Regression
Yes
Testing
Added.
Risk
Low - very targeted and single, simple fix (but in the query pipeline, which is never zero-risk). Quirk added.