Update discriminator columns when PK-to-PK dependent type is changed - #29876
Merged
Conversation
Contributor
Author
|
@AndriySvyryd I'm not sure if this is the correct fix, and also this scenario doesn't work for TPT or TPC. However, those cases are not regressions, so we may want to fix this case and leave the others for now. |
| var nonMainEntry = (!_mainEntryAdded || entry != _entries[0]) | ||
| || (updating | ||
| && (entry.EntityState == EntityState.Deleted | ||
| || entry.EntityState == EntityState.Added)); |
Member
There was a problem hiding this comment.
Rather than changing this add to the condition on 548 || entry.SharedIdentityEntry != null
Contributor
Author
There was a problem hiding this comment.
Seems to work. Thanks!
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AndriySvyryd
approved these changes
Dec 20, 2022
ajcvickers
added a commit
that referenced
this pull request
Dec 22, 2022
ajcvickers
added a commit
that referenced
this pull request
Dec 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29789
Also tests for #29874 and #29875